feat(js): Add OTEL support#1814
Merged
Jacob Lee (jacoblee93) merged 37 commits intomainfrom Jun 30, 2025
Merged
Conversation
Angus Jelinek (angus-langchain)
approved these changes
Jun 26, 2025
js/src/client.ts
Outdated
| ...this.autoBatchQueue.items.map(({ itemPromise }) => itemPromise), | ||
| this.batchIngestCaller.queue.onIdle(), | ||
| ]); | ||
| await getDefaultOTLPTracerComponents()?.spanProcessor?.forceFlush(); |
Collaborator
There was a problem hiding this comment.
this could block, do we need to flush always?
Collaborator
Author
There was a problem hiding this comment.
How would it block improperly? We want to wait for this to flush don't we?
|
Jacob Lee (@jacoblee93) not sure if it's useful, but we've recently started using OpenTelemetry tracing for inference. You obviously have very different constraints but maybe there's something that'll help: elastic/kibana#218694. |
Collaborator
Author
|
Dario Gieselaar (@dgieselaar) neat, thanks! Will take a look. LangSmith also has an endpoint that ingests OTEL already if interesting to you folks: https://docs.smith.langchain.com/observability/how_to_guides/trace_with_opentelemetry Just FYI rate limits are a bit lower at the moment |
David Duong (dqbd)
approved these changes
Jun 30, 2025
Isaac Francisco (isahers1)
pushed a commit
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC David Duong (@dqbd) Angus Jelinek (@angus-langchain)