Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ssl verifying part to work with httpx 0.28.0 #798

Merged
merged 3 commits into from
Dec 19, 2024
Merged

update ssl verifying part to work with httpx 0.28.0 #798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cd748f
update ssl verifying part to work with httpx 0.28.0
xxsl Dec 2, 2024
2866e70
lint
eyurtsev Dec 19, 2024
73d43aa
Merge branch 'main' into main
eyurtsev Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions langserve/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from urllib.parse import urljoin

import httpx
from httpx._types import AuthTypes, CertTypes, CookieTypes, HeaderTypes, VerifyTypes
from httpx._types import AuthTypes, CertTypes, CookieTypes, HeaderTypes
from langchain_core.callbacks import (
AsyncCallbackManagerForChainRun,
CallbackManagerForChainRun,
Expand Down Expand Up @@ -49,6 +49,11 @@

logger = logging.getLogger(__name__)

import typing

if typing.TYPE_CHECKING: # We simply follow the way httpx do
import ssl


def _is_json_serializable(obj: Any) -> bool:
"""Return True if the object is json serializable."""
Expand Down Expand Up @@ -281,7 +286,7 @@ def __init__(
auth: Optional[AuthTypes] = None,
headers: Optional[HeaderTypes] = None,
cookies: Optional[CookieTypes] = None,
verify: VerifyTypes = True,
verify: ssl.SSLContext | str | bool = True,
cert: Optional[CertTypes] = None,
client_kwargs: Optional[Dict[str, Any]] = None,
use_server_callback_events: bool = True,
Expand Down