Harrison/tiktoken spec #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR allows for `allowed_special` and `disallowed_special` parameters to be used (see issue #923 ). The default parameters for these are `set()` and `"all"` respectively [as per the code](https://github.com/openai/tiktoken/blob/main/tiktoken/core.py#L74). The reason this is needed is because when a GPT special token appears in some text to be encoded, an error will be raised (see issue #923 ) - using these special token params is the only way to get around it. Also added the same functionality for the `TokenTextSplitter`, so now this will work: ```python from langchain.text_splitter import TokenTextSplitter text_splitter = TokenTextSplitter.from_tiktoken_encoder( encoding_name=encoder_name, chunk_size=300, chunk_overlap=50 ) text_splitter.split_text( some_text, disallowed_special=() ) ```
Closed
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
Co-authored-by: James Briggs <[email protected]> Co-authored-by: Harrison Chase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.