Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally return shell output on incorrect command (#894) #899

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

hwchase17
Copy link
Contributor

This allows the LLM to correct its previous command by looking at the error message output to the shell.

Additionally, this uses subprocess.run because that is now recommended over subprocess.check_output:
https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module

This allows the LLM to correct its previous command by looking at the
error message output to the shell.

Additionally, this uses subprocess.run because that is now recommended
over subprocess.check_output:
https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module
@hwchase17 hwchase17 merged commit 93a091c into master Feb 6, 2023
@hwchase17 hwchase17 deleted the harrison/bash-incorrect branch February 6, 2023 20:46
@blob42 blob42 mentioned this pull request Feb 21, 2023
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
langchain-ai#899)

This allows the LLM to correct its previous command by looking at the
error message output to the shell.

Additionally, this uses subprocess.run because that is now recommended
over subprocess.check_output:

https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module

Co-authored-by: Amos Ng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants