Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak devcontainer #8154

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

finnless
Copy link
Contributor

Codespaces and devcontainer was broken by the repo restructure.

  • Description: Add libs/langchain to container so it can be built without error.
  • Issue: -
  • Dependencies: -
  • Tag maintainer: @hwchase17 @baskaryan
  • Twitter handle: @finnless

The failed build log says:

#10 [langchain-dev-dependencies 2/2] RUN poetry install --no-interaction --no-ansi --with dev,test,docs
#10 sha256:e850ee99fc966158bfd2d85e82b7c57244f47ecbb1462e75bd83b981a56a1929
2023-07-23 23:30:33.692Z: #10 0.827 
#10 0.827 Directory libs/langchain does not exist
2023-07-23 23:30:33.738Z: #10 ERROR: executor failed running [/bin/sh -c poetry install --no-interaction --no-ansi --with dev,test,docs]: exit code: 1

The new pyproject.toml imports from libs/langchain:

langchain/pyproject.toml

Lines 14 to 16 in 77bf75c

[tool.poetry.group.docs.dependencies]
langchain = { path = "libs/langchain/", develop = true }
autodoc_pydantic = "^1.8.0"

But libs/langchain is never added to the dev.Dockerfile:

# Copy only the dependency files for installation
COPY pyproject.toml poetry.toml ./

Create poetry toml at root
@baskaryan
Copy link
Collaborator

thanks @finnless!

@baskaryan baskaryan merged commit 7686dab into langchain-ai:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants