-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add params to reduce K dynamically to reduce it below token limit #739
Merged
hwchase17
merged 10 commits into
langchain-ai:master
from
Who828:reduce-token-below-limit-feature
Jan 27, 2023
Merged
Add params to reduce K dynamically to reduce it below token limit #739
hwchase17
merged 10 commits into
langchain-ai:master
from
Who828:reduce-token-below-limit-feature
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scadEfUr
reviewed
Jan 26, 2023
…ork of encoding multiple times
Made changes as per the comment. |
hwchase17
approved these changes
Jan 27, 2023
This would be super useful in general |
For all chains/agents which pick top k from multiple results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to #687, I implemented the functionality to reduce K if it exceeds the token limit.
Edit: I should have ran make lint locally. Also, this only applies to
StuffDocumentChain