Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze document #731

Merged
merged 6 commits into from
Feb 7, 2023
Merged

analyze document #731

merged 6 commits into from
Feb 7, 2023

Conversation

hwchase17
Copy link
Contributor

add analyze document chain, which does text splitting and then analysis

scadEfUr
scadEfUr approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@scadEfUr scadEfUr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm barring merge conflict!

just to make sure i understand -- when would you recommend using the AnalyzeDocumentChain with a qa_chain, instead of just using a qa_chain directly?

@hwchase17 hwchase17 merged commit 87fad8f into master Feb 7, 2023
@hwchase17 hwchase17 deleted the harrison/document-split branch February 7, 2023 04:02
@blob42 blob42 mentioned this pull request Feb 21, 2023
Closed
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
@hwchase17 @zachschillaci27
analyze document (langchain-ai#731)
522882b 
add analyze document chain, which does text splitting and then analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scadEfUr scadEfUr scadEfUr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwchase17 @scadEfUr