Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Myscale/improve string pattern match #6737

Closed
wants to merge 8 commits into from
Closed

Myscale/improve string pattern match #6737

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f6a3a44
fixed typo in myscale docs
mpskex Jun 25, 2023
627a0cb
Merge branch 'hwchase17:master' into master
mpskex Jun 25, 2023
3a763b5
revised prompted operator names
mpskex Jun 25, 2023
e6f3c77
Merge branch 'hwchase17:master' into myscale/improve_string_pattern_m…
mpskex Jun 26, 2023
1ff6f56
Merge branch 'hwchase17:master' into myscale/improve_string_pattern_m…
mpskex Jun 27, 2023
e72a84e
Merge branch 'hwchase17:master' into myscale/improve_string_pattern_m…
mpskex Jun 29, 2023
63e1405
Merge branch 'hwchase17:master' into myscale/improve_string_pattern_m…
mpskex Jul 5, 2023
4bcf01c
Merge branch 'hwchase17:master' into myscale/improve_string_pattern_m…
mpskex Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions langchain/chains/query_constructor/ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ class Comparator(str, Enum):
GTE = "gte"
LT = "lt"
LTE = "lte"
CONTAIN = "contain"
LIKE = "like"
CONTAIN = "list_contain"
LIKE = "string_pattern_like"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name still feels ambiguous to me, what is the LIKE comparison doing again? is it a regex match?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is just doing something like column LIKE '%pattern%'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think this function should be bounded with datatypes. Unfortunately I didn't find any place to insert the allowed datatypes with those functions. Do you have better idea?

We also explored some new ways to implement self-query retriever with openai's function call. We found pretrained LLMs are good SQL translator so it is probably a good new to SQL based vector databases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I probably misunderstand the issue. Do you mean the LIKE is ambiguous? Perhaps SUBSTRING_MATCH would be a better fit?



class FilterDirective(Expr, ABC):
Expand Down