Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in AnalyticDB Vector Store caused by upgrade SQLAlchemy version #6736

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

wangxuqi
Copy link
Contributor

Fixed bug in AnalyticDB VectorStore caused by the SQLAlchemy upgrade version to 1.4.47

The new version no longer supports the connection.commit() function, resulting in the error: AttributeError: 'Connection' object has no attribute 'commit'. Replace it with with conn.begin():.

This commit is related to VectorStores. @rlancemartin @eyurtsev

…sion to 1.4.47.

The new version no longer supports the `Connection.commit()` function, resulting in the error: AttributeError: 'Connection' object has no attribute 'commit'. Replace it with `with conn.begin()`.
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jun 26, 2023 2:34am

@rlancemartin rlancemartin self-assigned this Jun 26, 2023
Copy link
Collaborator

@rlancemartin rlancemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm notebook is functional following this update.

@wangxuqi
Copy link
Contributor Author

wangxuqi commented Jun 26, 2023

Please confirm notebook is functional following this update.

Confirmed. The notebook works well after this update.

@rlancemartin rlancemartin merged commit ec8247e into langchain-ai:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants