Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tags(str) to tags(dict) in mlflow_callback.py docs #6473

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

ArchimedesFTW
Copy link
Contributor

Fixes #6472

Who can review?

@agola11

@vercel
Copy link

vercel bot commented Jun 20, 2023

@ArchimedesFTW is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 20, 2023
@@ -117,7 +117,7 @@ class MlflowLogger:
Parameters:
name (str): Name of the run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're here, should these be run_name, experiment_name, and run_tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest matching the style of MLflow, which uses the variables run_name and experiment_name :
https://mlflow.org/docs/latest/python_api/mlflow.html#mlflow.run

However, MLflow doesn't use the parameter run_tags so I suggest keeping that to 'tags'. The documentation explains that they are tags for the run.

It should be important to note that if we change the parameter names, people who build code with the MLflow callback and set those parameters will have breaking code when they update to a newer version.

@dev2049 dev2049 merged commit fe941cb into langchain-ai:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Incorrect type for tags parameter in MLflow callback
3 participants