Skip to content

Conversation

@Ali-Ismail-1
Copy link
Contributor

Description:

  • Summary: Adds a unit test to ensure _generate raises a ValueError when streaming=True and multiple prompts are provided.
  • Motivation: Adds test coverage to address TODO in libs/partners/openai/langchain_openai/llms/base.py
  • Changes: Added a unit test for _generate

Test Plan

run the test file with
make test TEST_FILE=tests/unit_tests/llms/test_base.py

@vercel
Copy link

vercel bot commented Sep 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 30, 2025 10:28pm

@github-actions github-actions bot added the integration Related to a provider partner package integration label Sep 27, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #33134 will not alter performance

Comparing Ali-Ismail-1:feat/openai-llm-generate-unit-tests (52aaefa) with master (eddfcd2)1

Summary

✅ 6 untouched
⏩ 28 skipped2

Footnotes

  1. No successful run was found on master (84dbeba) during the generation of this report, so eddfcd2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 28 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

…ethod

- Add test for streaming error with multiple prompts
@Ali-Ismail-1 Ali-Ismail-1 force-pushed the feat/openai-llm-generate-unit-tests branch from 00d6beb to 8ea8ae4 Compare September 27, 2025 00:19
@Ali-Ismail-1 Ali-Ismail-1 changed the title test(openai): add openai unit test for streaming error in _generate test: add openai unit test for streaming error in _generate Sep 30, 2025
@Ali-Ismail-1 Ali-Ismail-1 changed the title test: add openai unit test for streaming error in _generate tests(openai): add openai unit test for streaming error in _generate Sep 30, 2025
@github-actions github-actions bot removed the integration Related to a provider partner package integration label Sep 30, 2025
@Ali-Ismail-1 Ali-Ismail-1 changed the title tests(openai): add openai unit test for streaming error in _generate test(openai): add openai unit test for streaming error in _generate Sep 30, 2025
@github-actions github-actions bot added the integration Related to a provider partner package integration label Sep 30, 2025
@github-actions github-actions bot added the infra Chores, devops, repo meta changes label Sep 30, 2025
@Ali-Ismail-1 Ali-Ismail-1 changed the title test(openai): add openai unit test for streaming error in _generate feat(openai): add openai unit test for streaming error in _generate Sep 30, 2025
@github-actions github-actions bot added feature and removed integration Related to a provider partner package integration infra Chores, devops, repo meta changes labels Sep 30, 2025
@ccurme ccurme requested a review from mdrxy as a code owner October 20, 2025 19:22
@github-actions github-actions bot added the integration Related to a provider partner package integration label Oct 20, 2025
@mdrxy mdrxy changed the title feat(openai): add openai unit test for streaming error in _generate feat(openai): add unit test for streaming error in _generate Oct 20, 2025
@github-actions github-actions bot added feature and removed feature labels Oct 20, 2025
@ccurme ccurme enabled auto-merge (squash) October 21, 2025 18:42
@ccurme ccurme self-assigned this Oct 21, 2025
@ccurme ccurme disabled auto-merge October 21, 2025 19:08
@ccurme ccurme merged commit 5acd34a into langchain-ai:master Oct 21, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature integration Related to a provider partner package integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants