Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: fix an issue with deepinfra integration #28715

Merged
merged 3 commits into from
Dec 14, 2024
Merged

community: fix an issue with deepinfra integration #28715

merged 3 commits into from
Dec 14, 2024

Conversation

JustNawaf
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: langchain: add URL parameter to ChatDeepInfra class

  • PR message: add URL parameter to ChatDeepInfra class

    • Description: This PR introduces a url parameter to the ChatDeepInfra class in LangChain, allowing users to specify a custom URL. Previously, the URL for the DeepInfra API was hardcoded to "https://stage.api.deepinfra.com/v1/openai/chat/completions", which caused issues when the staging endpoint was not functional. The _url method was updated to return the value from the url parameter, enabling greater flexibility and addressing the problem. out!

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 2:13am

@dosubot dosubot bot added community Related to langchain-community 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Dec 13, 2024
@JustNawaf
Copy link
Contributor Author

@efriis Could you kindly review this PR?

efriis
efriis approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change makes sense in this case

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 14, 2024
@efriis efriis enabled auto-merge (squash) December 14, 2024 02:13
@efriis efriis self-assigned this Dec 14, 2024
@efriis efriis merged commit decd77c into langchain-ai:master Dec 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

Assignees

@efriis efriis

Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustNawaf @efriis