community: use correct id_key when deleting by id in LanceDB wrapper

[floatplane]

• Description: The current version of the delete method assumes that the id field will always be called id.
• Issue: n/a
• Dependencies: n/a
• Twitter handle: ugh, Twitter :D

---

Thank you for contributing to LangChain!

• PR title: "package: description"

  • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
  • Example: "community: add foobar LLM"

• PR message: Delete this entire checklist and replace with

  • Description: a description of the change
  • Issue: the issue # it fixes, if applicable
  • Dependencies: any dependencies required for this change
  • Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!

• Add tests and docs: If you're adding a new integration, please include

  1. a test for the integration, preferably unit tests that do not rely on network access,
  2. an example notebook showing its use. It lives in docs/docs/integrations directory.

• Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

• Make sure optional dependencies are imported within a function.
• Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
• Most PRs should not touch more than one package.
• Changes should be backwards compatible.
• If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)	Visit Preview		Dec 11, 2024 11:45pm

[efriis]

Would also love to get this into a dedicated integration package in its own repo if you work at lancedb!

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

[floatplane]

Would also love to get this into a dedicated integration package in its own repo if you work at lancedb!

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

Sadly I don’t work at lancedb - just doing work for a startup that’s started using it and we bumped into this bug!

Thanks for the merge and hopefully someone at lancedb will pick this integration up 😁