core[patch]: return ToolMessage from tool #28605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
vbarda
reviewed
Dec 10, 2024
| @@ -954,10 +972,31 @@ class InjectedToolArg: | |||
| """Annotation for a Tool arg that is **not** meant to be generated by a model.""" | |||
|
|
|||
|
|
|||
| def _is_injected_arg_type(type_: type) -> bool: | |||
| class InjectedToolCallId(InjectedToolArg): | |||
There was a problem hiding this comment.
could we export this one from langchain_core.tools?
nfcampos
approved these changes
Dec 10, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Dec 10, 2024
| @@ -9,7 +9,11 @@ | |||
| from langchain_core.utils._merge import merge_dicts, merge_obj | |||
|
|
|||
|
|
|||
| class ToolMessage(BaseMessage): | |||
| class ToolOutputMixin: | |||
There was a problem hiding this comment.
Could you define what returning directly means in the doc-string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.