Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain-core: Fixed trim functions, and added corresponding unit test for the solved issue #28429

Merged
merged 2 commits into from
Dec 9, 2024
Merged

langchain-core: Fixed trim functions, and added corresponding unit test for the solved issue #28429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0190c6f
added fix for trim_first_node() and trim_last_node()
Tasif1 Nov 30, 2024
77b1eb8
added a unit test for trim functions
Tasif1 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions libs/core/langchain_core/runnables/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,14 +470,22 @@ def trim_first_node(self) -> None:
"""Remove the first node if it exists and has a single outgoing edge,
i.e., if removing it would not leave the graph without a "first" node."""
first_node = self.first_node()
if first_node and _first_node(self, exclude=[first_node.id]):
if (
first_node
and _first_node(self, exclude=[first_node.id])
and len({e for e in self.edges if e.source == first_node.id}) == 1
):
self.remove_node(first_node)

def trim_last_node(self) -> None:
"""Remove the last node if it exists and has a single incoming edge,
i.e., if removing it would not leave the graph without a "last" node."""
last_node = self.last_node()
if last_node and _last_node(self, exclude=[last_node.id]):
if (
last_node
and _last_node(self, exclude=[last_node.id])
and len({e for e in self.edges if e.target == last_node.id}) == 1
):
self.remove_node(last_node)

def draw_ascii(self) -> str:
Expand Down
20 changes: 20 additions & 0 deletions libs/core/tests/unit_tests/runnables/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,26 @@ class Schema(BaseModel):
assert graph.last_node() is end


def test_trim_multi_edge() -> None:
class Scheme(BaseModel):
a: str

graph = Graph()
start = graph.add_node(Scheme, id="__start__")
a = graph.add_node(Scheme, id="a")
last = graph.add_node(Scheme, id="__end__")

graph.add_edge(start, a)
graph.add_edge(a, last)
graph.add_edge(start, last)

graph.trim_first_node() # should not remove __start__ since it has 2 outgoing edges
assert graph.first_node() is start

graph.trim_last_node() # should not remove the __end__ node since it has 2 incoming edges
assert graph.last_node() is last


def test_graph_sequence(snapshot: SnapshotAssertion) -> None:
fake_llm = FakeListLLM(responses=["a"])
prompt = PromptTemplate.from_template("Hello, {name}!")
Expand Down
Loading