-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core]: Small Docstring Clarification for BaseTool
#28148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Nov 16, 2024
keenborder786
changed the title
[Core]:
[Core]: Small Docstring Clarification for Nov 16, 2024
kwargs
needs to be passed to BaseTool
runBaseTool
kapicic
reviewed
Nov 19, 2024
kapicic
reviewed
Nov 19, 2024
Co-authored-by: Stevan Kapicic <[email protected]>
Co-authored-by: Stevan Kapicic <[email protected]>
1 similar comment
efriis
approved these changes
Dec 9, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargs
are not being passed torun
of theBaseTool
which has been fixed