langchain_chroma: fixed integration tests #27968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:M
epinzur
changed the title
dosubot
bot
added
Ɑ: vector store
efriis
reviewed
Nov 12, 2024
efriis
added a commit
that referenced
this pull request
Dec 4, 2024
Description: * Added internal `Document.id` support to Chroma VectorStore Dependencies: * #27968 should be merged first and this PR should be re-based on top of those changes. Tests: * Modified/Added tests for `Document.id` support. All tests are passing. Note: I am not a member of the Chroma team. --------- Co-authored-by: Eugene Yurtsev <[email protected]> Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Document.idsupport to the Chroma VectorStore, but first I wanted to make sure all the integration tests were passing first. They weren't. This PR fixes the broken tests.Also ran
formatandlinton the changes.Note: I am not a member of the Chroma team.