anthropic[major]: support python 3.13 #27916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:M
|
Integration tests pass with 3.13 https://github.com/langchain-ai/langchain/actions/runs/11688847362 |
efriis
changed the title
efriis
reviewed
Nov 5, 2024
| if not self.count_tokens: | ||
| raise NameError("Please ensure the anthropic package is loaded") | ||
| return self.count_tokens(text) | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
to make this nonbreaking could we just call the new endpoint with a single humanmessage and subtract a constant number of standard tokens. (for e.g. Human: , and print a warning?
There was a problem hiding this comment.
Older models like claude 2 not supported unfortunately: https://docs.anthropic.com/en/docs/build-with-claude/token-counting#supported-models
baskaryan
reviewed
Nov 6, 2024
| @@ -1113,6 +1113,40 @@ class AnswerWithJustification(BaseModel): | |||
| else: | |||
| return llm | output_parser | |||
|
|
|||
| @beta() | |||
| def get_num_tokens_from_messages(self, messages: List[BaseMessage]) -> int: | |||
There was a problem hiding this comment.
thoughts on updating base implementation to take tools and/or kwargs? definitely not an anthropic-specific problem
dosubot
bot
added
size:L
baskaryan
reviewed
Nov 12, 2024
baskaryan
reviewed
Nov 12, 2024
Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week Anthropic released version 0.39.0 of its python sdk, which enabled support for Python 3.13. This release deleted a legacy
client.count_tokensmethod, which we currently access during init of theAnthropicLLM. Anthropic has replaced this functionality with the client.beta.messages.count_tokens() API.To enable support for
anthropic >= 0.39.0and Python 3.13, here we drop support for the legacy token counting method, and add support for the new method viaChatAnthropic.get_num_tokens_from_messages.To fully support the token counting API, we update the signature of
get_num_tokens_from_messageto accept tools everywhere.