LiteLLM Chat Model missing API key fix #27829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly check for the API keys before using the utility function
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
ccurme
reviewed
Nov 1, 2024
| @@ -302,28 +302,28 @@ def validate_environment(cls, values: Dict) -> Dict: | |||
| "Please install it with `pip install litellm`" | |||
| ) | |||
|
|
|||
| values["openai_api_key"] = get_from_dict_or_env( | |||
| values["openai_api_key"] = values.get("openai_api_key") or get_from_dict_or_env( | |||
There was a problem hiding this comment.
get_from_dict_or_env should be doing this:
langchain/libs/core/langchain_core/utils/env.py
Lines 46 to 47 in c3c638c
Could you write a unit test that fails with existing behavior and is fixed with your update, to demonstrate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly check for the API keys before using the utility function which should ideally fix the issue mentioned in #27826