Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: ChatSnowflakeCortex - Add streaming functionality #27753

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

PrathameshNimkar
Copy link
Contributor

Description:
snowflake.py
Add _stream and _stream_content methods to enable streaming functionality
fix pydantic issues and added functionality with the overall langchain version upgrade
added bind_tools method for agentic workflows support through langgraph
updated the _generate method to account for agentic workflows support through langgraph
cosmetic changes to comments and if conditions

snowflake.ipynb
Added _stream example
cosmetic changes to comments
fixed lint errors

check_pydantic.sh
Decreased counter from 126 to 125 as suggested when formatting

sfc-gh-pnimkar and others added 5 commits October 30, 2024 13:13
- Add _stream and _stream_content methods to enable streaming functionality
- fix pydantic issues and added functionality with the overall langchain version upgrade
- added bind_tools method for agentic workflows support through langgraph
- updated the _generate method to account for agentic workflows support through langgraph
- cosmetic changes to comments and if conditions

2. snowflake.ipynb
- Added _stream example
- cosmetic changes to comments

3. check_pydantic.sh
- Decreased counter from 126 to 125 as suggested when formatting
…treaming

community: ChatSnowflakeCortex - Add streaming functionality
Description:
Fix Lint Error of Snowflake Docs
…_error

docs: snowflake nb fix lint error
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 1:24am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Oct 30, 2024
@PrathameshNimkar PrathameshNimkar changed the title community,docs: ChatSnowflakeCortex - Add streaming functionality docs: ChatSnowflakeCortex - Add streaming functionality Oct 30, 2024
@PrathameshNimkar PrathameshNimkar changed the title docs: ChatSnowflakeCortex - Add streaming functionality community: ChatSnowflakeCortex - Add streaming functionality Oct 30, 2024
@efriis
Copy link
Member

efriis commented Oct 31, 2024

also cc @sfc-gh-nmoiseyev - probably best in the integration package

@PrathameshNimkar
Copy link
Contributor Author

@efriis - Do you mean to include this in the partner package please?
If not, please can you elaborate?

@sfc-gh-nmoiseyev
Copy link

@efriis - Do you mean to include this in the partner package please? If not, please can you elaborate?

Yes - we have a partner package in https://github.com/langchain-ai/langchain-snowflake and are working on migrating chat into it. It should be fine to land this here for now and we'll include it in the migration. Moving forward after migrating, all new PRs should be against that new package

@PrathameshNimkar
Copy link
Contributor Author

@efriis - have a you had a chance to review this please?

1 similar comment
@PrathameshNimkar
Copy link
Contributor Author

@efriis - have a you had a chance to review this please?

@efriis efriis self-assigned this Dec 12, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 12, 2024
@efriis efriis enabled auto-merge (squash) December 12, 2024 01:12
PrathameshNimkar and others added 2 commits December 11, 2024 21:20
- Decreasing the current_count value from 125 to 124
- This is done to remove the lint errors in github actions checks
…ease

community: chatSnowflakeCortex - Remove lint errors
auto-merge was automatically disabled December 12, 2024 02:25

Head branch was pushed to by a user without write access

Copy link

vercel bot commented Dec 12, 2024

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@efriis efriis merged commit ca054ed into langchain-ai:master Dec 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants