Confluence Loader: Fix CQL loading #27620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
|
@ccurme could you review the PR, please? |
|
@baskaryan, @efriis, @eyurtsev could you review the PR, please? |
ccurme
reviewed
Nov 26, 2024
libs/community/langchain_community/document_loaders/confluence.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/confluence.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/confluence.py
Outdated
Show resolved
Hide resolved
ccurme
reviewed
Nov 27, 2024
| docs.extend(batch) | ||
| break | ||
| else: | ||
| batch = get_pages(**kwargs, start=len(docs)) |
There was a problem hiding this comment.
does this need to be batch, _ = get(pages(...))?
There was a problem hiding this comment.
no, because for other than cql, it doesn't return anything except batch
ccurme
approved these changes
Dec 10, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12082