Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Fix missing protected_namespaces(). #27610

Conversation

gawbul
Copy link
Contributor

@gawbul gawbul commented Oct 24, 2024

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 24, 2024
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 3:09pm

@dosubot dosubot bot added community Related to langchain-community Ɑ: embeddings Related to text embedding models module labels Oct 24, 2024
@gawbul
Copy link
Contributor Author

gawbul commented Oct 24, 2024

Although I was seeing warnings for only a few of the embeddings, as detailed in the issue, I took the liberty to go through the code and update everywhere to avoid having to do this again in the future.

@eyurtsev eyurtsev self-requested a review October 25, 2024 02:14
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 25, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) October 25, 2024 02:15
@eyurtsev eyurtsev merged commit 24605bc into langchain-ai:master Oct 25, 2024
18 checks passed
@gawbul gawbul deleted the community-27609-fix-protected-namespace-warnings branch October 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants