core: fix Image prompt template hardcoded template format #27495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
vbarda
approved these changes
Oct 21, 2024
dosubot
bot
added
the
lgtm
5 tasks
ccurme
pushed a commit
that referenced
this pull request
Oct 22, 2024
Fixes #27411 **Description:** Adds `template_format` to the `ImagePromptTemplate` class and updates passing in the `template_format` parameter from ChatPromptTemplate instead of the hardcoded "f-string". Also updated docs and typing related to `template_format` to be more up-to-date and specific. **Dependencies:** None **Add tests and docs**: Added unit tests to validate fix. Needed to update `test_chat` snapshot due to adding new attribute `template_format` in `ImagePromptTemplate`. --------- Co-authored-by: Vadym Barda <[email protected]>
eyurtsev
reviewed
Oct 25, 2024
| @@ -1 +1,2 @@ | |||
| jinja2>=3,<4 | |||
| mustache>=0.1.4,<1 | |||
There was a problem hiding this comment.
why was this added? we vendor the implementation of mustache
There was a problem hiding this comment.
i added this because extended tests were failing for me https://github.com/langchain-ai/langchain/actions/runs/11448833821/job/31853195056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27411
Description: Adds
template_formatto theImagePromptTemplateclass and updates passing in thetemplate_formatparameter from ChatPromptTemplate instead of the hardcoded "f-string".Also updated docs and typing related to
template_formatto be more up-to-date and specific.Dependencies: None
Add tests and docs: Added unit tests to validate fix. Needed to update
test_chatsnapshot due to adding new attributetemplate_formatinImagePromptTemplate.