community: fixes json loader not getting texts with json standard #27327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
|
Tests failing due to how the new implementation handles string content. |
TonyBotongChu
force-pushed
the
fix-json-loader
branch
from
440c3bc to
505d7f7
Compare
dosubot
bot
added
size:M
TonyBotongChu
force-pushed
the
fix-json-loader
branch
from
505d7f7 to
e6c60c6
Compare
|
Fixed the string content problem. And I also modified file_path in test_json_loader.py, to make sure tests will work on windows. |
efriis
reviewed
Dec 12, 2024
| return json.dumps(content) if content else "" | ||
| else: | ||
| return str(content) if content is not None else "" | ||
| match content: |
There was a problem hiding this comment.
match statements were introduced in 3.10, but we support 3.9+. Please revert to if/elif
There was a problem hiding this comment.
this is fine but in general would recommend against changing both of these things together!
dosubot
bot
added
size:S
efriis
approved these changes
Dec 12, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes JSONLoader._get_text not converting objects to json string correctly.
If an object is serializable and is not a dict, JSONLoader will use python built-in str() method to convert it to string. This may cause object converted to strings not following json standard. For example, a list will be converted to string with single quotes, and if json.loads try to load this string, it will cause error.