-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: test 3.13 ci #27197
infra: test 3.13 ci #27197
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
601ade8
to
c82f6af
Compare
pyproject.toml
Outdated
[tool.poetry.group.dev.dependencies] | ||
langchain-core = { path = "libs/core/", develop = true } | ||
langchain-text-splitters = { path = "libs/text-splitters", develop = true } | ||
langchain-community = { path = "libs/community/", develop = true } | ||
langchain = { path = "libs/langchain/", develop = true } | ||
langchain-openai = { path = "libs/partners/openai", develop = true } | ||
ipykernel = "^6.29.2" | ||
|
||
# Support Python 3.8 and 3.12+. | ||
# Can be removed once the numpy version is fixed in langchain-community. | ||
numpy = [ | ||
{ version = "^1.24.0", python = "<3.12" }, | ||
{ version = "^1.26.0", python = ">=3.12" }, | ||
] | ||
[tool.poetry.group.typing.dependencies] | ||
|
||
[tool.poetry.group.test.dependencies] | ||
langchain-experimental = { git = "https://github.com/langchain-ai/langchain-experimental.git", subdirectory = "libs/experimental" } | ||
langchain-anthropic = { path = "libs/partners/anthropic", develop = true } | ||
langchain-chroma = { path = "libs/partners/chroma", develop = true } | ||
langchain-mistralai = { path = "libs/partners/mistralai", develop = true } | ||
langgraph = { git = "https://github.com/langchain-ai/langgraph.git", subdirectory = "libs/langgraph" } | ||
jupyter = "^1.1.1" | ||
click = "^8.1.7" | ||
faiss-cpu = "^1.7.4" | ||
pypdf = "^5.0.0" | ||
vcrpy = "^6.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these dependencies are needed for notebook tests
@@ -13,7 +13,7 @@ | |||
from langchain_community.utilities.requests import Requests | |||
|
|||
|
|||
class NLATool(Tool): | |||
class NLATool(Tool): # type: ignore[override] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooc what is driving the need for the new # type: ignores
? is it mypy getting updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead @override
overridden methods? I believe that might be what it's trying to enforce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(happy to merge this now and do a sprint on fixing ignores like this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccurme im not actually sure, afaict it was same mypy version. but issue was only happening in py3.13 so maybe im missing something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
not sure I understand all the type annotations. another option would be to upper-bound mypy at the old locked version, get 3.13 in, and then work on the mypy upgrade separately. I believe they're 2 different things (3.13 was more tests, mypy upgrade was more community lint)
@@ -13,7 +13,7 @@ | |||
from langchain_community.utilities.requests import Requests | |||
|
|||
|
|||
class NLATool(Tool): | |||
class NLATool(Tool): # type: ignore[override] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead @override
overridden methods? I believe that might be what it's trying to enforce
@@ -13,7 +13,7 @@ | |||
from langchain_community.utilities.requests import Requests | |||
|
|||
|
|||
class NLATool(Tool): | |||
class NLATool(Tool): # type: ignore[override] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(happy to merge this now and do a sprint on fixing ignores like this)
@@ -304,36 +304,38 @@ def _stream( | |||
"http_client": None, | |||
} | |||
|
|||
client = openai.OpenAI(**client_params) | |||
client = openai.OpenAI(**client_params) # type: ignore[arg-type, arg-type, arg-type, arg-type, arg-type, arg-type] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
No description provided.