Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TablestoreVectorStore. #25767

Merged
merged 21 commits into from
Dec 13, 2024
Merged

Add TablestoreVectorStore. #25767

merged 21 commits into from
Dec 13, 2024
+1,057 −0

Conversation

xjtushilei
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: community: add TablestoreVectorStore

  • PR message:

    • Description: add TablestoreVectorStore
    • Dependencies: none

  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration: yes
    2. an example notebook showing its use: yes

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 27, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 7:38am

@dosubot dosubot bot added community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Aug 27, 2024
@xjtushilei
Copy link
Contributor Author

@baskaryan Hello, I have already revised the previous comments. When you are free, can you help me take another look at the Review questions?

@xjtushilei
Copy link
Contributor Author

Hi， Any progress?

@xjtushilei
Copy link
Contributor Author

This PR has not made any progress for a long time, so I updated it to the latest branch and modified some formatting issues according to CI.

@baskaryan Please help merge this PR.

@xjtushilei xjtushilei requested a review from baskaryan December 13, 2024 07:37
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 13, 2024
@baskaryan baskaryan merged commit b0a2988 into langchain-ai:master Dec 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
PR Reviews
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xjtushilei @baskaryan