community[minor]: passthrough auth parameter on requests to Ollama-LLMs #24068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
eyurtsev
approved these changes
Jul 11, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Jul 11, 2024
| @@ -130,6 +130,10 @@ class _OllamaCommon(BaseLanguageModel): | |||
| tokens for authentication. | |||
| """ | |||
|
|
|||
| auth: Callable | tuple | None = None | |||
There was a problem hiding this comment.
I think you'll need to import
from __future__ import annotations
| @@ -1,5 +1,5 @@ | |||
| import json | |||
There was a problem hiding this comment.
Suggested change
| import json | |
| from __future__ import annotations | |
| import json |
eyurtsev
changed the title
dosubot
bot
added
size:S
eyurtsev
approved these changes
Jul 16, 2024
|
There are some broken unit tests. Are you able to resolve those? |
auto-merge was automatically disabled
July 23, 2024 08:29
Head branch was pushed to by a user without write access
dosubot
bot
added
size:M
|
I think I fixed the broken unit tests, but I'm not sure, because I'm having trouble running them locally. |
|
I fixed the remaining problem found by the linter. |
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
…Ms (langchain-ai#24068) Thank you for contributing to LangChain! **Description:** This PR allows users of `langchain_community.llms.ollama.Ollama` to specify the `auth` parameter, which is then forwarded to all internal calls of `requests.request`. This works in the same way as the existing `headers` parameters. The auth parameter enables the usage of the given class with Ollama instances, which are secured by more complex authentication mechanisms, that do not only rely on static headers. An example are AWS API Gateways secured by the IAM authorizer, which expects signatures dynamically calculated on the specific HTTP request. **Issue:** Integrating a remote LLM running through Ollama using `langchain_community.llms.ollama.Ollama` only allows setting static HTTP headers with the parameter `headers`. This does not work, if the given instance of Ollama is secured with an authentication mechanism that makes use of dynamically created HTTP headers which for example may depend on the content of a given request. **Dependencies:** None **Twitter handle:** None --------- Co-authored-by: Eugene Yurtsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Description:
This PR allows users of
langchain_community.llms.ollama.Ollamato specify theauthparameter, which is then forwarded to all internal calls ofrequests.request. This works in the same way as the existingheadersparameters. The auth parameter enables the usage of the given class with Ollama instances, which are secured by more complex authentication mechanisms, that do not only rely on static headers. An example are AWS API Gateways secured by the IAM authorizer, which expects signatures dynamically calculated on the specific HTTP request.Issue:
Integrating a remote LLM running through Ollama using
langchain_community.llms.ollama.Ollamaonly allows setting static HTTP headers with the parameterheaders. This does not work, if the given instance of Ollama is secured with an authentication mechanism that makes use of dynamically created HTTP headers which for example may depend on the content of a given request.Dependencies:
None
Twitter handle:
None