docs: api reference build fix #21496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:S
dosubot
bot
added
the
🤖:docs
efriis
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Agreed we should add standard tests to the build, but I don't think the whole build should proceed if a package fails? Isn't it better it fails loudly so we can go and fix it?
This runs daily to build api.python.langchain.com, and we get notifications when the build fails
|
@efriis Your comments addressed. |
|
outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: 1. The
create_api_rst.pyfails on thestandard-testsdirectory. 2. An error in building one package stops all build. Build should proceed with building the next package.Fix: added
standard-testsdirectory to the exception list. Added error handling for #2