Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruff v0.4.2 #21108

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Upgrade to Ruff v0.4.2 #21108

merged 1 commit into from
Apr 30, 2024

Conversation

charliermarsh
Copy link
Contributor

Summary

No new diagnostics (given that the set of enabled rules hasn't changed), but gains access to our new parser (much faster) and reduced false positives all around.

@efriis efriis added the partner label Apr 30, 2024
@efriis efriis self-assigned this Apr 30, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 30, 2024
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 6:26pm

@charliermarsh
Copy link
Contributor Author

More changes than I would've expected in the Poetry lock, but I ran with the same version (1.6.1) and poetry lock --no-update.

@dosubot dosubot bot added the 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Apr 30, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 30, 2024
@eyurtsev eyurtsev merged commit fd94aa8 into langchain-ai:master Apr 30, 2024
119 checks passed
@charliermarsh charliermarsh deleted the charlie/ruff branch April 30, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants