-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: adding AnySDK -- create toolkits from literally any SDK client #20491
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hwchase17 @eyurtsev updated AnySDK to use the new Tool stuff that's been introduced. also added example notebook. https://github.com/Barneyjm/langchain/blob/master/cookbook/any_sdk_example.ipynb Please rereview when you have a moment! Thank you |
@baskaryan @eyurtsev Can I please get a review on this PR? Please note that I've addressed some of @hwchase17 comments and added an example notebook as well Thank you! |
hi @baskaryan @efriis @eyurtsev @hwchase17 can this be merged? Happy to address any outstanding issues if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever! I'd be ok with this in experimental. I think it's a bit brittle for non-experimental though.
Let me know if you're interested in moving it! Sorry for the delay
Also just clarifying the security implications of this - it's dynamically routing between commands on an sdk that might be unexpected to the user, hence the risk (not guaranteed vulnerability, but risk). That's the desire to put in experimental |
Will close for now and feel free to reopen in experimental if desired! |
I've been building a lot of toolkits and found this was a quick and easy way to play with new SDKs without having to reinvent the wheel each time
Basic concept being:
Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.