Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: adding AnySDK -- create toolkits from literally any SDK client #20491

Closed
wants to merge 48 commits into from

Conversation

Barneyjm
Copy link
Contributor

I've been building a lot of toolkits and found this was a quick and easy way to play with new SDKs without having to reinvent the wheel each time

Basic concept being:

client = SomeSdk()
anysdk = AnySdkWrapper(client=client)

agent.invoke(“perform tasks X, Y, then Z”)

(The agent will then go and use the SDK to perform those tasks)

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 16, 2024
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain 🛑 Canceled (Inspect) Jun 21, 2024 3:48pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Apr 16, 2024
@Barneyjm
Copy link
Contributor Author

Barneyjm commented May 15, 2024

@hwchase17 @eyurtsev updated AnySDK to use the new Tool stuff that's been introduced.

also added example notebook. https://github.com/Barneyjm/langchain/blob/master/cookbook/any_sdk_example.ipynb

Please rereview when you have a moment! Thank you

@Barneyjm
Copy link
Contributor Author

@baskaryan @eyurtsev Can I please get a review on this PR? Please note that I've addressed some of @hwchase17 comments and added an example notebook as well

Thank you!

@Barneyjm
Copy link
Contributor Author

hi @baskaryan @efriis @eyurtsev @hwchase17

can this be merged? Happy to address any outstanding issues if needed

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
Copy link
Contributor

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever! I'd be ok with this in experimental. I think it's a bit brittle for non-experimental though.

Let me know if you're interested in moving it! Sorry for the delay

@efriis efriis removed the request for review from hwchase17 August 28, 2024 16:39
@efriis efriis self-assigned this Aug 28, 2024
@efriis
Copy link
Contributor

efriis commented Aug 28, 2024

Also just clarifying the security implications of this - it's dynamically routing between commands on an sdk that might be unexpected to the user, hence the risk (not guaranteed vulnerability, but risk).

That's the desire to put in experimental

@efriis
Copy link
Contributor

efriis commented Aug 29, 2024

Will close for now and feel free to reopen in experimental if desired!

@efriis efriis closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: agent Related to agents module community Related to langchain-community 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants