Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitbook document loader #1180

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

aletna
Copy link
Contributor

@aletna aletna commented Feb 20, 2023

Added a GitBook document loader. It lets you both, (1) fetch text from any single GitBook page, or (2) fetch all relative paths and return their respective content in Documents.

I've modified the scrape method in the WebBaseLoader to accept custom web paths if given, but happy to remove it and move that logic into the GitbookLoader itself.

@hwchase17
Copy link
Contributor

I've modified the scrape method in the WebBaseLoader to accept custom web paths if given, but happy to remove it and move that logic into the GitbookLoader itself.

i think best to have as static method on the class and have both call that shared logic, but im happy to refactor

@hwchase17 hwchase17 merged commit 23243ae into langchain-ai:master Feb 21, 2023
@aletna
Copy link
Contributor Author

aletna commented Feb 21, 2023

awesome, thanks!

@blob42 blob42 mentioned this pull request Feb 21, 2023
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
Added a GitBook document loader. It lets you both, (1) fetch text from
any single GitBook page, or (2) fetch all relative paths and return
their respective content in Documents.

I've modified the `scrape` method in the `WebBaseLoader` to accept
custom web paths if given, but happy to remove it and move that logic
into the `GitbookLoader` itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants