rfc: callback changes #1165
Merged
rfc: callback changes #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agola11
approved these changes
Feb 21, 2023
| action=action.tool, | ||
| tool_input=action.tool_input, | ||
| # TODO: this is duplicate info as above, not needed. | ||
| action=str(serialized), |
There was a problem hiding this comment.
I can rm this from the tracing backend and make the changes here next time we release a new tracing version
| @@ -68,7 +68,7 @@ def on_chain_error( | |||
|
|
|||
| @abstractmethod | |||
| def on_tool_start( | |||
| self, serialized: Dict[str, Any], action: AgentAction, **kwargs: Any | |||
| self, serialized: Dict[str, Any], input_str: str, **kwargs: Any | |||
There was a problem hiding this comment.
uber nit: tool_input seems like a better name?
Closed
zachschillaci27
pushed a commit
to zachschillaci27/langchain
that referenced
this pull request
Mar 8, 2023
conceptually, no reason a tool should know what an "agent action" is unless any objections, can change in all callback handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conceptually, no reason a tool should know what an "agent action" is
unless any objections, can change in all callback handlers