Skip to content

function to add documents to an existing chromadb vectorstore #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OmriNach
Copy link
Contributor

@OmriNach OmriNach commented Feb 19, 2023

Added function that takes in existing list of document objects to add to an already existing vector store object
fixes #1127

Added function that takes in existing list of document objects to add to an already existing vector store object
@hwchase17
Copy link
Contributor

i think we can put something at the base class that handles this - since you can just go from documents to texts + metadatas and then call the from_texts method on the base class

@hwchase17 hwchase17 changed the base branch from master to harrison/add-documents February 21, 2023 04:19
@hwchase17 hwchase17 merged commit 564871c into langchain-ai:harrison/add-documents Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chroma vectorstore has add_text method but no add_document method, even though it has from_document method
2 participants