Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harrison/align table #1081

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Harrison/align table #1081

merged 2 commits into from
Feb 16, 2023

Conversation

hwchase17
Copy link
Contributor

No description provided.

fpingham and others added 2 commits February 15, 2023 23:23
@fpingham @hwchase17
Align table info (#1051)
be22266 
Co-authored-by: Francisco Ingham <>
Co-authored-by: Harrison Chase <[email protected]>
@hwchase17
cr
b250933
@hwchase17 hwchase17 merged commit 5e10e19 into master Feb 16, 2023
@hwchase17 hwchase17 deleted the harrison/align-table branch February 16, 2023 07:53
dongreenberg pushed a commit to dongreenberg/langchain that referenced this pull request Feb 17, 2023
@hwchase17 @fpingham @dongreenberg
Harrison/align table (langchain-ai#1081)
45c2eae 
Co-authored-by: Francisco Ingham <[email protected]>
This was referenced Feb 17, 2023
Merged
Closed
hwchase17 pushed a commit that referenced this pull request Feb 17, 2023
@jzluo
fix for database compatibility when getting table DDL (#1129)
c39ef70 
#1081 introduced a method to get DDL (table definitions) in a manner
specific to sqlite3, thus breaking compatibility with other non-sqlite3
databases. This uses the sqlite3 command if the detected dialect is
sqlite, and otherwise uses the standard SQL `SHOW CREATE TABLE`. This
should fix #1103.
@blob42 blob42 mentioned this pull request Feb 21, 2023
Closed
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
@hwchase17 @fpingham @zachschillaci27
Harrison/align table (langchain-ai#1081)
012892f 
Co-authored-by: Francisco Ingham <[email protected]>
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
@jzluo @zachschillaci27
fix for database compatibility when getting table DDL (langchain-ai#1129
d48db18 
)

langchain-ai#1081 introduced a method to get DDL (table definitions) in a manner
specific to sqlite3, thus breaking compatibility with other non-sqlite3
databases. This uses the sqlite3 command if the detected dialect is
sqlite, and otherwise uses the standard SQL `SHOW CREATE TABLE`. This
should fix langchain-ai#1103.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwchase17 @fpingham