Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support (optional) direct return on SQLDatabaseChain to prevent passing data to LLM #821

Closed
zachschillaci27 opened this issue Jan 31, 2023 · 3 comments · Fixed by #864
Closed

Support (optional) direct return on SQLDatabaseChain to prevent passing data to LLM #821

zachschillaci27 opened this issue Jan 31, 2023 · 3 comments · Fixed by #864

Comments

@zachschillaci27
Copy link
Contributor

Thanks for the amazing open source work!

For certain data-sensitive projects, it may be important to silo the database and its contents (aside from table/column names) from any calls to the LLM. This means the LLM cannot be used for formatting the output of the SQL query. I suppose one way to support this would be to allow something like the Tool option return_direct in the SQLDatabaseChain chain, but perhaps there's a better way. I'm happy to help contribute as needed.
@hwchase17
Copy link
Contributor

love this idea, let me get on it

@hwchase17 hwchase17 linked a pull request Feb 3, 2023 that will close this issue
sql return direct #864
Merged
@hwchase17
Copy link
Contributor

thoughts on the above pr?

@zachschillaci27
Copy link
Contributor Author

thoughts on the above pr?

Looks great, thanks for the quick response!

@zachschillaci27 zachschillaci27 mentioned this issue Feb 3, 2023
Merged
hwchase17 pushed a commit that referenced this issue Feb 3, 2023
@zachschillaci27
Correct prompt typo + update example for SQLDatabaseChain (#868)
4c79100 
See #821
zachschillaci27 added a commit to zachschillaci27/langchain that referenced this issue Mar 8, 2023
@zachschillaci27
Correct prompt typo + update example for SQLDatabaseChain (langchain-…
74ac2c9 
…ai#868)

See langchain-ai#821
mikeknoop pushed a commit to zapier/langchain-nla-util that referenced this issue Mar 9, 2023
@zachschillaci27
Correct prompt typo + update example for SQLDatabaseChain (#868)
fcc32d0 
See langchain-ai/langchain#821
wertycn pushed a commit to wertycn/langchain-zh that referenced this issue Apr 26, 2023
@zachschillaci27
Correct prompt typo + update example for SQLDatabaseChain (#868)
70d9c7c 
See langchain-ai/langchain#821
ZinedineDumas added a commit to ZinedineDumas/React-Python that referenced this issue Jul 17, 2023
@ZinedineDumas @dashesy
Correct prompt typo + update example for SQLDatabaseChain (#868)
0d29628 
See langchain-ai/langchain#821
@dosubot dosubot bot mentioned this issue Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql return direct langchain-ai/langchain
2 participants
@hwchase17 @zachschillaci27