backward compatibility

langchain-ai · Nov 4, 2024 · 7b31bfe · 7b31bfe
1 parent 0ad9715
commit 7b31bfe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/libs/community/langchain_community/vectorstores/chroma.py b/libs/community/langchain_community/vectorstores/chroma.py
@@ -753,7 +753,11 @@ def update_documents(self, ids: List[str], documents: List[Document]) -> None:
         embeddings = self._embedding_function.embed_documents(text)
 
         if hasattr(
-            self._collection._client, "get_max_batch_size"
+            chroma_collection._client, "get_max_batch_size"
+        ):  # for Chroma 0.5.1 and above 
+        or
+        hasattr(
+            self._collection._client, "max_batch_size"
         ):  # for Chroma 0.4.10 and above
             from chromadb.utils.batch_utils import create_batches
 
@@ -823,8 +827,12 @@ def from_texts(
         if ids is None:
             ids = [str(uuid.uuid4()) for _ in texts]
         if hasattr(
+            chroma_collection._client, "get_max_batch_size"
+        ):  # for Chroma 0.5.1 and above 
+        or
+        hasattr(
             chroma_collection._client,  # type: ignore[has-type]
-            "get_max_batch_size",  # type: ignore[has-type]
+            "max_batch_size",  # type: ignore[has-type]
         ):  # for Chroma 0.4.10 and above
             from chromadb.utils.batch_utils import create_batches
 

diff --git a/libs/partners/chroma/langchain_chroma/vectorstores.py b/libs/partners/chroma/langchain_chroma/vectorstores.py
@@ -997,7 +997,11 @@ def update_documents(self, ids: List[str], documents: List[Document]) -> None:
         embeddings = self._embedding_function.embed_documents(text)
 
         if hasattr(
-            self._collection._client, "get_max_batch_size"
+            chroma_collection._client, "get_max_batch_size"
+        ):  # for Chroma 0.5.1 and above 
+        or
+        hasattr(
+            self._collection._client, "max_batch_size"
         ):  # for Chroma 0.4.10 and above
             from chromadb.utils.batch_utils import create_batches
 
@@ -1071,6 +1075,10 @@ def from_texts(
             ids = [str(uuid.uuid4()) for _ in texts]
         if hasattr(
             chroma_collection._client, "get_max_batch_size"
+        ):  # for Chroma 0.5.1 and above 
+        or
+        hasattr(
+            self._collection._client, "max_batch_size"
         ):  # for Chroma 0.4.10 and above
             from chromadb.utils.batch_utils import create_batches