Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error when stop reason missing in response. #57

Merged
merged 2 commits into from
May 23, 2024

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented May 23, 2024

Fixes #55, #56.

All integration tests pass.

(base) ➜  aws git:(fix-stop-reason-error) make integration_tests             
poetry run pytest tests/integration_tests/
================================================================== test session starts ==================================================================
platform darwin -- Python 3.9.13, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/pijain/projects/langchain-aws-dev/langchain-aws/libs/aws
configfile: pyproject.toml
plugins: syrupy-4.6.1, anyio-4.3.0, cov-4.1.0, asyncio-0.23.6
asyncio: mode=auto
collected 34 items                                                                                                                                      

tests/integration_tests/test_compile.py .                                                                                                         [  2%]
tests/integration_tests/chat_models/test_bedrock.py ...................                                                                           [ 58%]
tests/integration_tests/embeddings/test_bedrock_embeddings.py .....s...                                                                           [ 85%]
tests/integration_tests/llms/test_sagemaker_endpoint.py ..                                                                                        [ 91%]
tests/integration_tests/retrievers/test_amazon_kendra_retriever.py .                                                                              [ 94%]
tests/integration_tests/retrievers/test_amazon_knowledgebases_retriever.py ..                                                                     [100%]
====================================================== 33 passed, 1 skipped, 2 warnings in 50.68s =======================================================

@3coins
Copy link
Collaborator Author

3coins commented May 23, 2024

@arm-diaz @thekrol01 @supreetkt
Can you review and verify this change fixes the issue. Thanks.

@3coins 3coins marked this pull request as ready for review May 23, 2024 18:46
@3coins 3coins added the bug Something isn't working label May 23, 2024
@3coins 3coins self-assigned this May 23, 2024
@arm-diaz
Copy link

This looks good. Thank you @3coins !

@thekrol01
Copy link

thekrol01 commented May 23, 2024

Same here, looks good! Great work @3coins !

@3coins 3coins merged commit 57ea56b into langchain-ai:main May 23, 2024
12 checks passed
@supreetkt
Copy link

Tried a few models as well. Looks good to me.

@nithiyn
Copy link

nithiyn commented May 24, 2024

Thank you!

@3coins 3coins deleted the fix-stop-reason-error branch December 4, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Mistral Models are not working for ChatBedrock & BedrockLLM
5 participants