Add min_score_confidence support for the Bedrock KB retriver #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add min_score_confidence field to AmazonKnowledgeBasesRetriever class - add unit tests and integration tests to test score - update kendra retriver _filter_by_score_confidence doc string
|
cc @rozerarenu to review this PR. |
rozerarenu
approved these changes
May 21, 2024
|
Thanks for having a look and approving @rozerarenu and @3coins! Any thoughts on when this would be merged and put into a release? I'm currently extending the Let me know if there is anything else I can help with to get this into a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
min_score_confidencesupport for the Bedrock KB retriverAmazonKnowledgeBasesRetrieverclass_filter_by_score_confidencedoc stringCloses: #48