Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xfail from passing integration tests. #232

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Oct 10, 2024

Some of the tests marked xfail are passing in my local testing. Enabling them, so these run during the release.

tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_tool_message_histories_string_content PASSED
tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_tool_message_histories_list_content PASSED
tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_structured_few_shot_examples PASSED

@3coins 3coins marked this pull request as ready for review October 10, 2024 18:52
@3coins
Copy link
Collaborator Author

3coins commented Oct 10, 2024

cc @baskaryan

@3coins 3coins merged commit 09eef16 into langchain-ai:main Oct 17, 2024
12 checks passed
@3coins 3coins deleted the enable-passing-tests branch December 4, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant