Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes get provider for model_ids with region prefix. Added unit tests. #184

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Sep 6, 2024

Fixes #178

@3coins 3coins marked this pull request as ready for review September 6, 2024 05:12
Copy link

@rsgrewal-aws rsgrewal-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@shabie shabie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@3coins 3coins merged commit 4aebf17 into langchain-ai:main Sep 6, 2024
12 checks passed
@3coins 3coins deleted the fix-get-provider branch December 4, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-region support for Bedrock
3 participants