Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ChatBedrock for llama3 #115

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fixes ChatBedrock for llama3 #115

merged 1 commit into from
Jul 18, 2024

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Jul 17, 2024

Fixes #90

@3coins 3coins mentioned this pull request Jul 17, 2024
Closed
@3coins
Copy link
Collaborator Author

3coins commented Jul 18, 2024

@ccurme
Thanks for approving this change. There seems to be a related issue which is failing streaming use cases, would you be able to help with this? I can make the necessary changes, if this is an oversight in langchain-aws.

@ccurme ccurme merged commit 8a17693 into langchain-ai:main Jul 18, 2024
12 checks passed
@ccurme
Copy link
Contributor

ccurme commented Jul 18, 2024

@ccurme Thanks for approving this change. There seems to be a related issue which is failing streaming use cases, would you be able to help with this? I can make the necessary changes, if this is an oversight in langchain-aws.

Believe this is a bug in langchain-aws that is fixed in the ChatBedrockConverse implementation
cc @baskaryan

@3coins 3coins deleted the fix-issue-90 branch December 4, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llama3-70b chat no longer functioning with Bedrock
2 participants
@3coins @ccurme