Repository navigation
feat(langsmith): enable SMITHDB_UPGRADE_CRON_ENABLED by default - #868
Merged
Anirudh Satish (asatish-langchain) merged 1 commit intoJul 29, 2026
Merged
Conversation
Bakes SMITHDB_UPGRADE_CRON_ENABLED=true into the shared LangSmith ConfigMap when smithdb.enabled is true, alongside the other stable- smithdb feature-flag defaults introduced in #848. ClickHouse-only clusters remain unaffected — the key is gated on the same {{- if .Values.smithdb.enabled }} block, so app code defaults apply. Adds positive/negative unittest coverage mirroring the pattern used for the other stable-smithdb keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Anirudh Satish (asatish-langchain)
requested a review
from a team
as a code owner
July 29, 2026 00:51
ben (ben11211)
approved these changes
Jul 29, 2026
Anirudh Satish (asatish-langchain)
enabled auto-merge (squash)
July 29, 2026 00:55
Anirudh Satish (asatish-langchain)
deleted the
anirudh/enable-smithdb-upgrade-cron
branch
July 29, 2026 01:05
Anirudh Satish (asatish-langchain)
added a commit
that referenced
this pull request
Jul 29, 2026
Bagatur (baskaryan)
added a commit
that referenced
this pull request
Jul 30, 2026
* Bump langsmith appVersion to 0.16.22rc1 (#842) * Bump langsmith appVersion 0.16.21rc1 -> 0.16.22rc1 * Bump langsmith chart version to 0.16.0-rc.17 * Bump langsmith appVersion to 0.16.23rc1 (#853) * fix(langsmith): normalize SmithDB OTLP endpoint scheme (#843) * fix(langsmith): normalize SmithDB OTLP endpoint scheme Derive the URI scheme required by SmithDB from the chart's TLS setting while preserving the bare endpoint consumed by existing LangSmith services. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(langsmith): allow disabling SmithDB tracing Keep shared TLS tracing available to LangSmith services by adding a SmithDB-specific opt-out and validating TLS only when SmithDB export remains enabled. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(langsmith): disable SmithDB tracing with TLS Keep TLS tracing available to supported services while SmithDB falls back to console logging until its OTLP exporter supports TLS. Co-authored-by: Cursor <cursoragent@cursor.com> * refactor(langsmith): simplify SmithDB tracing condition Use the chart's explicit TLS setting as the source of truth for SmithDB exporter compatibility. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(langsmith): clarify SmithDB TLS fallback Distinguish disabled OTLP tracing from console-formatted stdout logging. Co-authored-by: Cursor <cursoragent@cursor.com> * refactor(langsmith): simplify SmithDB endpoint normalization Make plaintext normalization explicit now that TLS compatibility is handled before rendering the endpoint. Co-authored-by: Cursor <cursoragent@cursor.com> * refactor(langsmith): prepend SmithDB OTLP scheme directly Rely on the chart's bare endpoint contract instead of accepting protocol-bearing values. Co-authored-by: Cursor <cursoragent@cursor.com> * feat(langsmith): enable SmithDB OTLP TLS Derive SmithDB's required endpoint URI scheme from the shared TLS setting while preserving the bare endpoint used by other services. --------- Co-authored-by: Cursor <cursoragent@cursor.com> * feat: backport agent IAM providers to v16-stable (#852) * feat: configure agent database IAM providers Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: validate agent IAM providers Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix: nest agent IAM providers under external databases Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: bump v16 chart version to 0.16.0-rc.18 Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: joaquin-borggio-lc <213688804+joaquin-borggio-lc@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix(langsmith): template TRIGGER_SERVER_ENDPOINT in shared ConfigMap [v16-stable] (#856) * fix(langsmith): template TRIGGER_SERVER_ENDPOINT in shared ConfigMap v16-stable port. Fleet trigger proxy/client in platform-backend and the tool-server need TRIGGER_SERVER_ENDPOINT. Wire the in-cluster trigger-server URL into the shared ConfigMap when fleet + fleetTriggerServer are enabled so customers do not need to set commonEnv. Co-authored-by: Cursor <cursoragent@cursor.com> * chore: drop TRIGGER_SERVER_ENDPOINT unittest Co-authored-by: Cursor <cursoragent@cursor.com> * chore: drop TRIGGER_SERVER_ENDPOINT config-map comments Co-authored-by: Cursor <cursoragent@cursor.com> * chore: bump chart version by one (rc.19) Only increment from v16-stable's rc.18 instead of jumping to rc.22. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * feat(langsmith): bake stable-smithdb flag defaults into config-map (#848) (#860) Extends the main -config ConfigMap with the LangSmith app feature-flag envs that differ from code defaults for a stable SmithDB-backed deployment. New SMITHDB_* / RUN_RULES_SMITHDB_* keys are gated on smithdb.enabled (same block as SMITHDB_CLUSTER_MANAGER_ENABLED), so ClickHouse-only clusters keep app code defaults. RUN_RULES_TWO_POINTER_BACKFILL_TENANTS is non-SmithDB-specific and emitted unconditionally. Values.yaml gains typed knobs under smithdb.langsmith.* and config.runRules.twoPointerBackfillTenants for operator overrides. * fix(langsmith): configure plaintext OTLP exporters (#859) Set the standard OpenTelemetry insecure flag from useTls so Python exporters connect correctly to plaintext collectors while preserving TLS behavior. * Bump langsmith appVersion to 0.16.24rc1 (#863) Advance v16-stable chart defaults to the newly published 0.16.24rc1 images and bump the chart package to 0.16.0-rc.20. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(langsmith): remove deprecated bundled agent-bootstrap; validate on use (#841) Remove the bundled agent-bootstrap Job (backend.agentBootstrap) and its glue: the bootstrap-job/rbac templates, its test, its values, the three agentBootstrap.* helpers, and the -agent-builder-config configMap mounts it created at runtime. Standalone agents (top-level fleet/insights/polly deployments) replace it, so config.agentBuilder is retained (fleet uses it as fallback defaults). Add a validate.yaml gate: if backend.agentBootstrap is still set, fail with a message directing users to contact LangChain support for migration guidance. * fix(langsmith): set AUTH_ENDPOINT in the shared ConfigMap [v16-stable] (#846) * fix(langsmith): set AUTH_ENDPOINT on the agent gateway The gateway resolves frontend bearer tokens against the auth service and reads AUTH_ENDPOINT, which the chart never set. Whenever the gateway cannot build a local auth backend it panics at startup with: panic: gateway frontend bearer authentication requires AUTH_ENDPOINT for AUTH_TYPE "mixed" Point AUTH_ENDPOINT at the platform-backend service, the same target LANGSMITH_AUTH_ENDPOINT already uses in the shared ConfigMap. Scoped to the gateway Deployment rather than the ConfigMap so the other services' resolution of AUTH_ENDPOINT is unchanged. Chart version goes to rc.19 rather than rc.18 so this branch and main do not publish different charts under the same version. * refactor(langsmith): move AUTH_ENDPOINT to the shared ConfigMap AUTH_ENDPOINT was set as an inline env var on the agent gateway Deployment only. Move it to the shared ConfigMap alongside GO_ENDPOINT and LANGSMITH_AUTH_ENDPOINT, which already resolve to the same platform-backend service. The gateway already consumes the shared ConfigMap via envFrom, so it still receives the value. Setting it centrally also covers every other consumer of AUTH_ENDPOINT instead of the single Deployment we happened to patch. Replace the gateway-scoped test with a ConfigMap suite covering the key's presence across each authType branch, that it matches LANGSMITH_AUTH_ENDPOINT, custom platformBackend name/port/clusterDomain, and the gateway's envFrom reference that delivers it. * Bump langsmith appVersion to 0.16.25rc1 (#865) Advance v16-stable chart defaults to the newly published 0.16.25rc1 images and bump the chart package to 0.16.0-rc.22. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: align ace backend resources with SaaS defaults (#866) (#867) Co-authored-by: Alex Kira <43946+akira@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat(langsmith): enable SMITHDB_UPGRADE_CRON_ENABLED by default (#868) (#869) Set SMITHDB_UPGRADE_CRON_ENABLED=true into the shared LangSmith ConfigMap when smithdb.enabled is true (cherry picked from commit e17caa5) * feat(langsmith): enable RULES_REDIS_TRACKING for SmithDB ingestion (#871) Bakes RULES_REDIS_TRACKING_ENABLED=true and RULES_REDIS_TRACKING_MULTIPART_ENABLED=true into the shared LangSmith ConfigMap when smithdb.langsmith.ingestion.enabled is true — the "dual" (ClickHouse + SmithDB) and "smithdb only" ingestion modes. The Run Rules scheduler already reads from Redis (gated in #848 by SMITHDB_RULES_REDIS_READ_ENABLED / _THREAD_ variants), but the ingestion pipeline was not writing tracking entries there. These app-side flags default to false, so we opt in from the chart whenever SmithDB is doing the ingesting. Placed in the existing `{{- if .Values.smithdb.langsmith.ingestion.enabled }}` block alongside SMITHDB_MUTATIONS_SERVICE_URL / SMITHDB_INGESTION_SERVICE_URL, so ClickHouse-only clusters remain on app code defaults (both false). Unittest coverage: positive assertions in the dual-mode and smithdb-only ingestion cases; notExists assertions in the disabled case. Co-authored-by: Anirudh Satish <asatish@langchain.dev> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * fix(langsmith): set TaskDB resource defaults (#872) Give the chart-managed migration TaskDB guaranteed CPU and memory so it does not run with BestEffort QoS. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: cap Run Rules backfills at one day (#875) Co-authored-by: ben <1986620+ben11211@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add priorityClassName to all workloads (#876) * feat: add priorityClassName to StatefulSets Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat: add priorityClassName to deployments Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * chore: align priorityClassName placement Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * ci: rerun transient helm repository check Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> --------- Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> * feat(langsmith): set RUN_RULES_QUERY_LIMIT for SmithDB installs (#879) Set RUN_RULES_QUERY_LIMIT=250 in the shared LangSmith ConfigMap when smithdb.enabled is true, covering the "dual" (ClickHouse + SmithDB) and "SmithDB only" self-hosted modes. Pure-ClickHouse installs keep the application default. --------- Co-authored-by: ben <nagengast@langchain.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: joaquin-borggio-lc <joaquin@langchain.dev> Co-authored-by: joaquin-borggio-lc <213688804+joaquin-borggio-lc@users.noreply.github.com> Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com> Co-authored-by: Anirudh Satish <asatish@langchain.dev> Co-authored-by: Mukil Loganathan <mukil@langchain.dev> Co-authored-by: Alex Kira <alex.kira@gmail.com> Co-authored-by: Alex Kira <43946+akira@users.noreply.github.com> Co-authored-by: ben <1986620+ben11211@users.noreply.github.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SMITHDB_UPGRADE_CRON_ENABLED=trueinto the shared LangSmith ConfigMap whensmithdb.enabledis true