Skip to content

feat(langsmith): bake stable-smithdb flag defaults into config-map [v16-stable] #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anirudh Satish (asatish-langchain) merged 1 commit into from
Jul 27, 2026
Merged

feat(langsmith): bake stable-smithdb flag defaults into config-map [v16-stable] #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions charts/langsmith/templates/config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ data:
{{- if .Values.smithdb.enabled }}
SMITHDB_CLUSTER_MANAGER_ENABLED: "true"
SMITHDB_CLUSTER_MANAGER_URL: {{ include "langsmith.smithdb.grpcServiceUrl" (dict "root" . "component" "clusterManager" "port" .Values.smithdb.clusterManager.service.port) | quote }}
SMITHDB_QUERY_SERVICE_MAX_CALL_RECV_MSG_SIZE: "1073741824"
SMITHDB_FEEDBACK_MUTATION_RPS_PER_KEY: "100"
SMITHDB_FEEDBACK_MUTATION_BURST_PER_KEY: "150"
SMITHDB_RULES_REDIS_READ_ENABLED: "true"
SMITHDB_RULES_THREAD_REDIS_READ_ENABLED: "true"
RUN_RULES_SMITHDB_RETRIEVER_TENANTS: '["*"]'
RUN_RULES_SMITHDB_RETRIEVER_PCT: "100"
RUN_RULES_SMITHDB_THREAD_RETRIEVER_TENANTS: '["*"]'
RUN_RULES_SMITHDB_THREAD_RETRIEVER_PCT: "100"
{{- end }}
{{- if .Values.config.hostname }}
# Remote MCP server / OAuth Authorization Server (served under /api). The AS only
Expand Down Expand Up @@ -84,6 +93,8 @@ data:
{{- end }}
FF_RUN_STATS_GROUP_BY_ENABLED_ALL: "true"
SEPARATE_QUEUES_WITH_SINGLE_WORKER: '["host"]'
RUN_RULES_REDIS_DEDUP_TENANTS: '["*"]'
RUN_RULES_LIMIT_RRA_RECORDS_PER_BATCH_TENANTS: '["*"]'
{{- if .Values.config.observability.tracing.enabled }}
OTEL_TRACING_ENABLED: "{{ .Values.config.observability.tracing.enabled }}"
OTLP_ENDPOINT: "{{ .Values.config.observability.tracing.endpoint }}"
Expand Down
53 changes: 53 additions & 0 deletions charts/langsmith/tests/langsmith_smithdb_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,39 @@ tests:
- equal:
path: data.SMITHDB_MUTATIONS_SERVICE_URL
value: RELEASE-NAME-langsmith-smithdb-query.NAMESPACE.svc.cluster.local:8080
- equal:
path: data.SMITHDB_QUERY_SERVICE_MAX_CALL_RECV_MSG_SIZE
value: "1073741824"
- equal:
path: data.SMITHDB_FEEDBACK_MUTATION_RPS_PER_KEY
value: "100"
- equal:
path: data.SMITHDB_FEEDBACK_MUTATION_BURST_PER_KEY
value: "150"
- equal:
path: data.SMITHDB_RULES_REDIS_READ_ENABLED
value: "true"
- equal:
path: data.SMITHDB_RULES_THREAD_REDIS_READ_ENABLED
value: "true"
- equal:
path: data.RUN_RULES_SMITHDB_RETRIEVER_TENANTS
value: '["*"]'
- equal:
path: data.RUN_RULES_SMITHDB_RETRIEVER_PCT
value: "100"
- equal:
path: data.RUN_RULES_SMITHDB_THREAD_RETRIEVER_TENANTS
value: '["*"]'
- equal:
path: data.RUN_RULES_SMITHDB_THREAD_RETRIEVER_PCT
value: "100"
- equal:
path: data.RUN_RULES_REDIS_DEDUP_TENANTS
value: '["*"]'
- equal:
path: data.RUN_RULES_LIMIT_RRA_RECORDS_PER_BATCH_TENANTS
value: '["*"]'

- it: should configure SmithDB ingestion without SmithDB query endpoints
values:
Expand Down Expand Up @@ -376,6 +409,26 @@ tests:
path: data.SMITHDB_CLUSTER_MANAGER_ENABLED
- notExists:
path: data.SMITHDB_CLUSTER_MANAGER_URL
- notExists:
path: data.SMITHDB_QUERY_SERVICE_MAX_CALL_RECV_MSG_SIZE
- notExists:
path: data.SMITHDB_FEEDBACK_MUTATION_RPS_PER_KEY
- notExists:
path: data.SMITHDB_RULES_REDIS_READ_ENABLED
- notExists:
path: data.RUN_RULES_SMITHDB_RETRIEVER_TENANTS
- notExists:
path: data.RUN_RULES_SMITHDB_RETRIEVER_PCT
- notExists:
path: data.RUN_RULES_SMITHDB_THREAD_RETRIEVER_TENANTS
- notExists:
path: data.RUN_RULES_SMITHDB_THREAD_RETRIEVER_PCT
- equal:
path: data.RUN_RULES_REDIS_DEDUP_TENANTS
value: '["*"]'
- equal:
path: data.RUN_RULES_LIMIT_RRA_RECORDS_PER_BATCH_TENANTS
value: '["*"]'

- it: should omit frontend SmithDB v2 endpoint flag when disabled
values:
Expand Down
Loading