Skip to content

fix(langsmith): configure plaintext OTLP exporters #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben (ben11211) merged 1 commit into from
Jul 28, 2026
Merged

fix(langsmith): configure plaintext OTLP exporters #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/langsmith/templates/config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ data:
OTEL_ENVIRONMENT: "{{ .Values.config.observability.tracing.env }}"
OTEL_EXPORTER: "{{ .Values.config.observability.tracing.exporter }}"
OTEL_USE_TLS: "{{ .Values.config.observability.tracing.useTls }}"
OTEL_EXPORTER_OTLP_INSECURE: {{ (not .Values.config.observability.tracing.useTls) | quote }}
{{- else }}
OTEL_TRACING_ENABLED: "false"
OTLP_ENDPOINT: ""
Expand Down
20 changes: 20 additions & 0 deletions charts/langsmith/tests/langsmith_smithdb_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,26 @@ tests:
- equal:
path: data.OTLP_ENDPOINT
value: default-otel-collector:4317
- equal:
path: data.OTEL_EXPORTER_OTLP_INSECURE
value: "true"

- it: should configure secure OTLP transport for LangSmith services
values:
- ./values/smithdb-enabled.yaml
set:
config.observability.tracing.enabled: true
config.observability.tracing.endpoint: secure-otel-collector:4317
config.observability.tracing.useTls: true
config.observability.tracing.exporter: grpc
template: config-map.yaml
asserts:
- equal:
path: data.OTLP_ENDPOINT
value: secure-otel-collector:4317
- equal:
path: data.OTEL_EXPORTER_OTLP_INSECURE
value: "false"

- it: should derive the TLS SmithDB OTLP endpoint from chart-level tracing
values:
Expand Down
Loading