fix(code): hide startup tips when resuming threads - #5349
Merged
Conversation
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
github-actions
Bot
added
dcode
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
Mason Daugherty (mdrxy)
marked this pull request as ready for review
August 6, 2026 05:23
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
The startup-tip remount ran inside `_resolve_resume_thread`'s `finally` ahead of `_resume_thread_resolved_event.set()`. `suppress(NoMatches)` does not cover `MountError` or `WrongType`, so a mount failure skipped `set()` and stranded `_write_launch_name_memory`, hanging onboarding and killing the server-startup worker. Signal resolution first, then restore the tip behind its own handler. Narrow the suppress to the two lookups it actually covers and log a miss instead of vanishing silently. Drop the post-mount re-check: `Widget.mount` registers synchronously before it suspends, so a dismissal during the await already removes the tip itself. Cover the successful-resume case, all three remaining fallback branches, the hide-tips opt-out, and the restore-failure invariant. Clear `DEEPAGENTS_CODE_HIDE_SPLASH_TIPS` in conftest so tip assertions cannot pass vacuously.
Alexander Olsen (aolsenjazz)
pushed a commit
that referenced
this pull request
Aug 7, 2026
> [!CAUTION] > Merging this PR will automatically publish to **PyPI** and create a **GitHub release**. For the full release process, see [`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md). --- _Release notes preview: keep this section in sync with the package `CHANGELOG.md`. Publish reads the merged CHANGELOG via `release.yml`, not this PR description — keep them aligned anyway so the PR stays an accurate historical record for reviewers and anyone returning later._ --- ## [0.1.54](deepagents-code==0.1.53...deepagents-code==0.1.54) (2026-08-07) ### Features - Added Meta `muse-spark-1.2` to the model switcher ([#5389](#5389)). - Improved diff readability with quieter hunks and word-level highlights ([#5106](#5106)). ### Bug Fixes - Hid startup tips when resuming threads ([#5349](#5349)). - Prevented post-tool hook replay ([#5376](#5376)). - Stored update logs under the OS cache directory ([#5363](#5363)). _End release notes preview._ --- > [!NOTE] > A **New Contributors** section is appended to the GitHub release notes automatically at publish time (see [Release Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline), step 2). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: langchain-oss-automated-triage[bot] <248757908+langchain-oss-automated-triage[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumed threads no longer show a startup discovery tip above the chat input.
Startup tips are only relevant to fresh sessions and otherwise displace resumed context from the input.
Made by Open SWE