fix(code): always restart after a successful startup auto-update - #5317
Merged
Mason Daugherty (mdrxy) merged 8 commits intoAug 6, 2026
Merged
Conversation
The startup auto-update rewrites the site-packages the running process imports from, so continuing in-process after a successful install leaves a mixed-version interpreter: the TUI is loaded from the new code while already-imported modules stay on the old release. The splash reads `__version__` from `_version`, which `__init__.py` imports eagerly, so it reported the pre-upgrade version — and a renamed constant made 0.1.51 to 0.1.52 fail outright with an `ImportError` at TUI startup. Two paths led there. `detect_shadowed_dcode` reported a `dcode` symlink that points *into* the upgraded tool venv as a conflict, and the caller skipped the restart on that signal even though `_restart_current_process` re-execs `sys.executable` and never consults PATH. And a failed re-exec launched anyway instead of asking the user to relaunch. Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
github-actions
Bot
added
dcode
Mason Daugherty (mdrxy)
marked this pull request as ready for review
August 5, 2026 23:14
Record the auto-update cooldown on both paths that exit after a successful install. Neither reaches a next generation, so the `restarted_for` sentinel guard cannot cover them: a successful-but-no-op upgrade paired with a persistently failing `os.execv` would otherwise re-upgrade and re-exit on every launch, leaving the TUI unreachable. The write is best-effort — the reason for exiting is often the same unwritable state dir `mark_startup_auto_update_failed` trips over, and it runs inside an `except`, so an unguarded raise would escape uncaught. `_exit_after_unrestartable_update` now distinguishes its two callers. A failed re-exec keeps the existing wording and exits 0. An error after the install says so, names the error, points at the debug log, and exits 1 — claiming a restart "could not run" sent users chasing an exec problem that never happened, and the traceback only reached the in-memory buffer that dies with the process, so exiting 0 left the failure invisible to the user, the terminal, the log and the exit status at once. Retarget the PATH-shadow warning at the next manual launch. It read "will keep running the old version on relaunch" while being printed immediately before a restart that loads the new version. Raise the unresolvable-entry-point log to `warning`, matching the sibling guard in `detect_shadowed_dcode`: the consequence is a user-visible warning about a PATH conflict that may not exist. Cover the sentinel assignment, the cooldown writes, the print ordering, the late-window post-install failure and the unresolvable-target fallback. Each new guard is mutation-verified.
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
Mason Daugherty (mdrxy)
deleted the
open-swe/auto-update-restart-after-upgrade
branch
August 6, 2026 00:59
Mason Daugherty (mdrxy)
pushed a commit
that referenced
this pull request
Aug 6, 2026
> [!CAUTION] > Merging this PR will automatically publish to **PyPI** and create a **GitHub release**. For the full release process, see [`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md). --- _Release notes preview: keep this section in sync with the package `CHANGELOG.md`. Publish reads the merged CHANGELOG via `release.yml`, not this PR description — keep them aligned anyway so the PR stays an accurate historical record for reviewers and anyone returning later._ --- ## [0.1.53](deepagents-code==0.1.52...deepagents-code==0.1.53) (2026-08-06) ### Features - Added pricing coverage with Baseten built-in overrides and local fallback overrides when `genai-prices` is missing data ([#5312](#5312), [#5304](#5304)). - Suggest compacting large resumed threads ([#5318](#5318)). - Added terminal program trace metadata ([#5329](#5329)). ### Bug Fixes - Preserved runtime offload archive routing ([#5328](#5328)). - Always restart after a successful startup auto-update ([#5317](#5317)). - Fixed leaked turn coroutines and SQLite handles ([#5218](#5218)). - Keep MCP shutdown-race tracebacks from appearing in the terminal ([#5325](#5325)). - Open the `/auto model` selector immediately while connecting ([#5341](#5341)). - Route failures to `PostToolUseFailure` ([#5315](#5315)). - Use dismissed copy for ask-user prompts ([#5331](#5331)). _End release notes preview._ --- > [!NOTE] > A **New Contributors** section is appended to the GitHub release notes automatically at publish time (see [Release Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline), step 2). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: langchain-oss-automated-triage[bot] <248757908+langchain-oss-automated-triage[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a startup auto-update installs,
dcodenow always restarts into the new version instead of continuing with a mix of old and new code — which could crash startup with anImportErroror show the old version on the splash screen. If the restart cannot happen, it prints the new version and asks you to relaunch rather than starting a broken session.The install rewrites the site-packages the running process imports from, so modules already loaded stay on the old release while the TUI loads from the new one; a constant added in 0.1.52 made that combination crash.
PATHEXTcandidates only inside uv’s bin directory. This recognizes.cmdaliases to uv’s.exeshim and prevents a project-local executable from becoming the auto-update restart target.os.execvprints a relaunch hint and exits0; other post-install errors name the error, point at the debug log, and exit1. Both record the update cooldown so a persistently failing re-exec cannot loop forever.