Skip to content

fix(code): hydrate transcript tail when scrolled to the bottom edge - #4733

Merged
Mason Daugherty (mdrxy) merged 1 commit into
mainfrom
mdrxy/code/fix-flaky-tail-hydration
Jul 14, 2026
Merged

fix(code): hydrate transcript tail when scrolled to the bottom edge#4733
Mason Daugherty (mdrxy) merged 1 commit into
mainfrom
mdrxy/code/fix-flaky-tail-hydration

Conversation

@mdrxy

@mdrxy Mason Daugherty (mdrxy) commented Jul 14, 2026

Copy link
Copy Markdown
Member

Fix newest transcript messages sometimes failing to reappear when scrolling to the bottom of a long, virtualized chat history.


test_scroll_down_hydrates_tail_below was flaky (~30% TimeoutError) because scroll-driven tail hydration compared the message store's estimated bottom_spacer_top against the real DOM scroll geometry (scroll_y/max_scroll_y). When estimated spacer heights drift from the rendered layout — which depends on the viewport height Textual happens to allocate — the distance heuristic can sit exactly at its threshold while the view is already parked at max_scroll, so should_hydrate_below returns False forever and the archived tail is never remounted.

should_hydrate_below now hydrates whenever the view is at the scroll edge but history remains archived below, mirroring how scrolling to offset 0 always hydrates above. This is a real user-facing fix, not just a test tweak: a user who scrolls to the very bottom while the tail is archived would otherwise be stranded on a blank spacer.

Made by Open SWE

Scroll-driven tail hydration compared the store's estimated
`bottom_spacer_top` against the real DOM scroll geometry. When estimated
spacer heights drift from the rendered layout, the distance check can sit
exactly at its threshold while the view is parked at `max_scroll`,
stranding the archived tail forever. This made
`test_scroll_down_hydrates_tail_below` flaky (viewport-height dependent).

`should_hydrate_below` now hydrates whenever the view is at the scroll
edge but history remains archived below, mirroring how scrolling to
offset 0 always hydrates above.

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
@github-actions github-actions Bot added dcode Related to `deepagents-code` fix A bug fix (PATCH) internal User is a member of the `langchain-ai` GitHub organization size: S 50-199 LOC labels Jul 14, 2026
@mdrxy
Mason Daugherty (mdrxy) marked this pull request as ready for review July 14, 2026 20:04

@open-swe open-swe Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in WebView Open SWE trace

@mdrxy
Mason Daugherty (mdrxy) merged commit 02a2461 into main Jul 14, 2026
84 of 85 checks passed
@mdrxy
Mason Daugherty (mdrxy) deleted the mdrxy/code/fix-flaky-tail-hydration branch July 14, 2026 20:15
Mason Daugherty (mdrxy) pushed a commit that referenced this pull request Jul 16, 2026
> [!CAUTION]
> Merging this PR will automatically publish to **PyPI** and create a
**GitHub release**.

For the full release process, see
[`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md).

---

_Release notes preview: keep this section in sync with the package
`CHANGELOG.md`. The published GitHub release body is extracted from the
merged `CHANGELOG.md` by `release.yml`, not from this PR description._

---


##
[0.1.40](deepagents-code==0.1.39...deepagents-code==0.1.40)
(2026-07-16)

### Features

- Added plugin marketplace support
([#4554](#4554)).
- Added an “always allow” option to the project MCP approval prompt
([#4562](#4562)).
- Improved `/goal` workflows: criteria generation now runs server-side,
YOLO mode auto-accepts criteria, goals complete after satisfied grading,
and goal review editing now supports `Ctrl+X`
([#4754](#4754),
[#4784](#4784),
[#4781](#4781),
[#4780](#4780)).
- Reasoning effort now persists across restarts
([#4728](#4728)).
- Added a toast prompting you to re-paste when a chat paste collapses
([#4742](#4742)).

### Bug Fixes

- Tool calls awaiting approval are now surfaced correctly
([#4739](#4739)).
- Fixed transcript tail hydration when scrolled to the bottom edge
([#4733](#4733)).
- Kept chat input responsive during MCP viewer `Ctrl+R` reconnects
([#4753](#4753)).
- Improved inline free-text prompts by sharing paste handling and
matching primary-input `Ctrl+D` behavior
([#4736](#4736),
[#4729](#4729)).
- Fixed local offloaded tool results to use the real filesystem
([#4740](#4740)).
- Cleaned offloaded history when deleting a thread
([#4751](#4751)).
- Removed duplicated content from the system prompt by overwriting the
base prompt
([#4516](#4516)).
- Closed subprocess transport during install teardown
([#4735](#4735)).
- Added targeted `uv` constraints for prerelease dependencies
([#4744](#4744)).

_End release notes preview._

---

> [!NOTE]
> A **New Contributors** section is appended to the GitHub release notes
automatically at publish time (see [Release
Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline),
step 2).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: langchain-oss-automated-triage[bot] <248757908+langchain-oss-automated-triage[bot]@users.noreply.github.com>
Marcelo5444 pushed a commit to Marcelo5444/deepagents that referenced this pull request Jul 30, 2026
…angchain-ai#4733)

Fix newest transcript messages sometimes failing to reappear when
scrolling to the bottom of a long, virtualized chat history.

---

`test_scroll_down_hydrates_tail_below` was flaky (~30% `TimeoutError`)
because scroll-driven tail hydration compared the message store's
*estimated* `bottom_spacer_top` against the *real* DOM scroll geometry
(`scroll_y`/`max_scroll_y`). When estimated spacer heights drift from
the rendered layout — which depends on the viewport height Textual
happens to allocate — the distance heuristic can sit exactly at its
threshold while the view is already parked at `max_scroll`, so
`should_hydrate_below` returns `False` forever and the archived tail is
never remounted.

`should_hydrate_below` now hydrates whenever the view is at the scroll
edge but history remains archived below, mirroring how scrolling to
offset 0 always hydrates above. This is a real user-facing fix, not just
a test tweak: a user who scrolls to the very bottom while the tail is
archived would otherwise be stranded on a blank spacer.

Made by [Open
SWE](https://openswe.vercel.app/agents/9bce6e12-3555-8aa4-3e10-0a96a898db03)

Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Marcelo5444 pushed a commit to Marcelo5444/deepagents that referenced this pull request Jul 30, 2026
> [!CAUTION]
> Merging this PR will automatically publish to **PyPI** and create a
**GitHub release**.

For the full release process, see
[`.github/RELEASING.md`](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md).

---

_Release notes preview: keep this section in sync with the package
`CHANGELOG.md`. The published GitHub release body is extracted from the
merged `CHANGELOG.md` by `release.yml`, not from this PR description._

---


##
[0.1.40](langchain-ai/deepagents@deepagents-code==0.1.39...deepagents-code==0.1.40)
(2026-07-16)

### Features

- Added plugin marketplace support
([langchain-ai#4554](langchain-ai#4554)).
- Added an “always allow” option to the project MCP approval prompt
([langchain-ai#4562](langchain-ai#4562)).
- Improved `/goal` workflows: criteria generation now runs server-side,
YOLO mode auto-accepts criteria, goals complete after satisfied grading,
and goal review editing now supports `Ctrl+X`
([langchain-ai#4754](langchain-ai#4754),
[langchain-ai#4784](langchain-ai#4784),
[langchain-ai#4781](langchain-ai#4781),
[langchain-ai#4780](langchain-ai#4780)).
- Reasoning effort now persists across restarts
([langchain-ai#4728](langchain-ai#4728)).
- Added a toast prompting you to re-paste when a chat paste collapses
([langchain-ai#4742](langchain-ai#4742)).

### Bug Fixes

- Tool calls awaiting approval are now surfaced correctly
([langchain-ai#4739](langchain-ai#4739)).
- Fixed transcript tail hydration when scrolled to the bottom edge
([langchain-ai#4733](langchain-ai#4733)).
- Kept chat input responsive during MCP viewer `Ctrl+R` reconnects
([langchain-ai#4753](langchain-ai#4753)).
- Improved inline free-text prompts by sharing paste handling and
matching primary-input `Ctrl+D` behavior
([langchain-ai#4736](langchain-ai#4736),
[langchain-ai#4729](langchain-ai#4729)).
- Fixed local offloaded tool results to use the real filesystem
([langchain-ai#4740](langchain-ai#4740)).
- Cleaned offloaded history when deleting a thread
([langchain-ai#4751](langchain-ai#4751)).
- Removed duplicated content from the system prompt by overwriting the
base prompt
([langchain-ai#4516](langchain-ai#4516)).
- Closed subprocess transport during install teardown
([langchain-ai#4735](langchain-ai#4735)).
- Added targeted `uv` constraints for prerelease dependencies
([langchain-ai#4744](langchain-ai#4744)).

_End release notes preview._

---

> [!NOTE]
> A **New Contributors** section is appended to the GitHub release notes
automatically at publish time (see [Release
Pipeline](https://github.com/langchain-ai/deepagents/blob/main/.github/RELEASING.md#release-pipeline),
step 2).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: langchain-oss-automated-triage[bot] <248757908+langchain-oss-automated-triage[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dcode Related to `deepagents-code` fix A bug fix (PATCH) internal User is a member of the `langchain-ai` GitHub organization size: S 50-199 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant