Harrison/0.0.2 - #3
Merged
Merged
Conversation
Yuchen Zhang (yuchenzhang)
referenced
this pull request
in aihehuo/deepagents
Jun 20, 2026
- Created detailed test report for wu_tanchang_api multi-turn dialog testing - Confirmed Issue #2 (post-delivery short reply) is explicit design via code review: - _has_delivered_material() gate (chat.py:175-198) - _GUIDE_MESSAGE constant (chat.py:22-24) - FRONTEND_SYSTEM_PROMPT_TEMPLATE enforces workflow (agent.py:133-135) - Issue #3 logger.exception already present in chat.py:262-276, needs logging config verification - Issue #1 remains open (FilesystemMiddleware path crossing) Co-Authored-By: Claude <noreply@anthropic.com>
John Kennedy (jkennedyvz)
pushed a commit
that referenced
this pull request
Jun 21, 2026
…e _default_suffix, document group drops - send_media: replace if/else branch duplication with (method, file_field) tuple selection - _check_telegram_size: avoid redundant stat() call — the size is already checked by validate_media_size; reword the error without re-statting - _safe_suffix: inline the single-caller _default_suffix helper - TelegramChannel: document that group/supergroup messages are silently dropped and add a debug log in _message_values when chat type mismatches Fixes #3, #5, #14, #15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.