move to deep agents - #2
Merged
Merged
Conversation
jamesskelton-nexefy
referenced
this pull request
in jamesskelton-nexefy/deepagentsv3
Aug 26, 2025
* add filesystem * stash * cr * cr * cr * cr * cr * stash * stash * cr * cr
james8814
pushed a commit
to james8814/deepagents
that referenced
this pull request
May 1, 2026
External team's impact assessment (辩证结论 langchain-ai#2) correctly identified that interrupt_on inheritance (acad9bb) exists upstream but was never merged into master. upstream-sync-round11 branch was not merged; architect applied selective fixes directly on master instead. - CLAUDE.md: Mark interrupt_on inheritance as "upstream only, not merged" - SDK_UPGRADE_GUIDE.md: Mark as "尚未合入" with current vs planned behavior Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
james8814
pushed a commit
to james8814/deepagents
that referenced
this pull request
May 3, 2026
… v5 langchain-ai#22 + langchain-ai#23） CTO 自 audit 3 findings (D2-A1/fork-diff-A1/H3-A1) 修订完整闭环。本 commit 是 §6.1 A 组 3 项 CTO domain spec 修订（A1+, A4, A5）。 A1+ H-3 §3.2.5 反向测试要求（应用 langchain-ai#22） - Phase 1 装配支援包 H-3 §3.2 增"反向测试要求"section - 每项 invariant 必须配反向验证（破坏 invariant 看是否 FAIL） - 含 T-3 反向验证模板供 pmagent 复制到其他 12 项 - 触发: pmagent v1.6 audit MEDIUM langchain-ai#2 (仅 T-3 反向，T-1~T-13 单向 assertion 风险) A4 D-2 v2 §6 R-3 对照测试覆盖（应用 langchain-ai#22） - 单元测试 spec 增 3 项对照测试要求: ① 嵌套 SubAgent (subagent 调用 subagent) hook 触发对照 ② async dispatch vs sync dispatch 双路径对照 ③ 多 hook 订阅者 firing 顺序对照 - 触发: CTO 自 audit D2-A1 finding (设计未要求实施时做对照测试) A5 fork-vs-pypi-diff-evaluation.md spec（应用 langchain-ai#23） - 创建独立 spec 文档（之前仅 message 形式，不在 git tracking） - §3.3 测试驱动评估方法（替代主观"是否仍依赖"判断） - §3.2 失败 → V2 子类化决策树 - §5 完整 verification 章节（应用 ADR v5 langchain-ai#23 SOP） - 估时 2-3 h（绿灯）/ +1-3 d V2 子类化（黄灯）/ 翻盘 ADR（红灯） - 触发: CTO 自 audit fork-diff-A1 finding (缺可执行评估方法) 应用 ADR v5 全套 (langchain-ai#16-langchain-ai#23): - langchain-ai#16: 所有 finding 配具体行号引用 + commit hash - langchain-ai#17: fidelity 量化 (fork diff 数据来自 1c3a85a 实证 +3,798 行) - langchain-ai#22: 三个 spec 修订全部含对照实验要求 - langchain-ai#23: A5 创建独立 spec 文档含 verification 章节（CTO 第 8 次失误教训：spec 必须 git tracked，不依赖记忆 sync） 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Yuchen Zhang (yuchenzhang)
referenced
this pull request
in aihehuo/deepagents
Jun 20, 2026
- Created detailed test report for wu_tanchang_api multi-turn dialog testing - Confirmed Issue #2 (post-delivery short reply) is explicit design via code review: - _has_delivered_material() gate (chat.py:175-198) - _GUIDE_MESSAGE constant (chat.py:22-24) - FRONTEND_SYSTEM_PROMPT_TEMPLATE enforces workflow (agent.py:133-135) - Issue #3 logger.exception already present in chat.py:262-276, needs logging config verification - Issue #1 remains open (FilesystemMiddleware path crossing) Co-Authored-By: Claude <noreply@anthropic.com>
John Kennedy (jkennedyvz)
pushed a commit
that referenced
this pull request
Jun 21, 2026
…line dispatch_message FilteredMediaPaths and filter_capped_media_paths were only used by the WhatsApp channel, not shared across channels. Move them from base.py into whatsapp.py as module-private helpers. Inline the three-line dispatch_message helper into both channels _dispatch methods — the indirection added no value. Fixes #2 and #11 (WhatsApp side).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.