Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flag to turn on compression #40

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Conversation

Mokosha
Copy link
Contributor

@Mokosha Mokosha commented Jul 18, 2019

I'm not sure if this actually does what I want it to, since I didn't really know how to test this change locally. Basically the idea is that for the requests that support gzip or similar, we should actually zip the data that we send. This gives a reduction of about 93% (!) which speeds up the fetching of, e.g., a year's worth of data considerably.

@sahilda
Copy link
Member

sahilda commented Jul 18, 2019

Try starting the app and curling the endpoints to see if you're getting the desired results.

@sahilda
Copy link
Member

sahilda commented Jul 19, 2019

@Mokosha I'll merge and deploy. Don't think there's any harm although it seems like from online people don't use this actually compress methods, and use other means like a CDN or a load balancer.

@sahilda sahilda merged commit f35c0fd into master Jul 19, 2019
@sahilda sahilda deleted the feature/enable-compression branch July 19, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants